Coming soon - Get a detailed view of why an account is flagged as spam!
view details

This post has been de-listed

It is no longer included in search results and normal feeds (front page, hot posts, subreddit posts, etc). It remains visible only via the author's post history.

306
Tips for dealing with someone who writes insanely complex/fragile code?
Post Body

Been in my team as a mid level engineer for about 6 years now and all was going well until we hired this new developer. Don't get me wrong, they're INSANELY smart. My manager loves them as they basically have an answer to any technical problem and have put them on the pedestal. However, ever since they joined, they have been committing code that is insanely complex with no comments.

Seems like everyone else on the team is also struggling, and finding more bugs and taking longer to resolve bugs because the code is just so complex.

At least in my personal experience:

  • I've spent time after work walking through code, just to understand what is going on or rewriting code to make it much easier to read which typically resolves bugs
  • Dealt with more and more bugs, that have been increasingly more challenging to debug
  • Increased likelihood for things to break if we add new features with how fragile the code is
  • Encounter code that's basically been copy/pasted multiple times in the code, when the logic can be put into a function and called.

Any suggestions?

Edit:

  • We (as a team) have talked to our manager, but our input just gets thrown into thin air because "their code is working"
  • When we code review, we ask for more concise/reusable code, but then get told that we're just blocking PR's from rolling out by the manager and this new engineer.

Author
Account Strength
60%
Account Age
2 years
Verified Email
Yes
Verified Flair
No
Total Karma
1,421
Link Karma
824
Comment Karma
597
Profile updated: 11 hours ago
Posts updated: 9 months ago

Subreddit

Post Details

We try to extract some basic information from the post title. This is not always successful or accurate, please use your best judgement and compare these values to the post title and body for confirmation.
Posted
9 months ago