Coming soon - Get a detailed view of why an account is flagged as spam!
view details
19
Comparing the ABC code to Core
Post Body

I'm making a special post to show how the code can be compared against the Core baseline commit (964a185cc83) on top of which ABC was developed.

The direct comparison would result in a bit of a hard-to-read diff because the ABC codebase was cleaned up (a lot of file reformatted for readability / consistency and future maintainability purpose).

So to compare, we would want to eliminate the "reformatting" differences as much as possible.

I created a branch which is the Core baseline, but with those files modified by ABC already being reformatted using the same style rules.

Here is a tool which you can run on Linux to fetch the special branch and create a diff.

Bash script to obtain the difference, excl. formatting changes (gist link)

See the file header of that script for more info. You can run it on a Linux system (with git) by running it through the bash interpreter.

It also leaves the repo it downloads, so you can do further examination between the 'baseline' (reformatted) and the 'master' (current Bitcoin-ABC development head) branch.

You will notice that the diff is still quite large!

This is because ABC did touch a lot of files - it goes beyond a "minimal" fork because

  • it removes Segwit RBF (a big chunk of code)
  • it adds ABC functionality (kind of a big deal that Core never got around to, with new tests etc)
  • includes new docs (UAHF spec)
  • add UAHF forking implementation (parameters, triggering, tests)

So, quite a bit of code.

I hope to produce a more detailed overview of the changes.

Feel free to ask questions though - we welcome further review and inquisitive minds!

Most of all, please download, try to build it on your platforms, run the test suites and report the results to us!

Author
Account Strength
100%
Account Age
8 years
Verified Email
Yes
Verified Flair
No
Total Karma
20,629
Link Karma
7,328
Comment Karma
12,869
Profile updated: 12 hours ago
Posts updated: 9 months ago

Subreddit

Post Details

We try to extract some basic information from the post title. This is not always successful or accurate, please use your best judgement and compare these values to the post title and body for confirmation.
Posted
7 years ago